Hello, MediaWiki:Gadget-removeAccessKeys.js looks for an optional array window.removeAccessKeys, to be defined in the user's javascript. Thus, the dependency user should be added to this gadget's entry. Regards, Od1n (talk) 17:09, 24 February 2018 (UTC)
user is for other purposes. This gadget waits until the page load, so user JavaScript should have been run by that. —Tacsipacsi (talk) 20:27, 24 February 2018 (UTC)It's quite tricky, I know... user is not mediawiki.user. The former is really to ensure beforehand loading of <user>/common.js, <user>/common.css, etc. References: search 'user' in Resources.php, then see ResourceLoaderUserModule.php. Od1n (talk) 11:43, 26 February 2018 (UTC)Oh, I see. However, as I said, not declaring the dependency should have no impact on the results, not even in edge cases. (It doesn’t mean that we should not declare it, but I don’t see it as an absolute and urgent necessity.) —Tacsipacsi (talk) 19:26, 26 February 2018 (UTC)The "DOM ready" event makes the code execute later, but it's really a different thing. Maybe it works in practice, but you should consider it as luck. Just add the dependency to do things properly. Indeed this fix is not an urgent one, but it's still a fix, and a good practice to spread. Od1n (talk) 12:49, 28 February 2018 (UTC)I didn’t say it should be leaved unfixed, feel free to ask an admin to do that (I’m not one). —Tacsipacsi (talk) 14:14, 28 February 2018 (UTC)
Sure thing, I have just added the template for requesting edit. Od1n (talk) 23:45, 28 February 2018 (UTC)
Please clarify exactly what change needs to be made? — Martin (MSGJ · talk) 18:05, 1 March 2018 (UTC)
Replace existing line with this one:
removeAccessKeys[ResourceLoader|dependencies=user,jquery.accessKeyLabel]|removeAccessKeys.js
Od1n (talk) 18:49, 1 March 2018 (UTC)